Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new discretiser: sorts variables in bins, and replaces bins by target mean value #394

Open
solegalli opened this issue Mar 25, 2022 · 4 comments · May be fixed by #419
Open

new discretiser: sorts variables in bins, and replaces bins by target mean value #394

solegalli opened this issue Mar 25, 2022 · 4 comments · May be fixed by #419
Labels
new transformer New feature or request wontfix This will not be worked on

Comments

@solegalli
Copy link
Collaborator

We can use the functionality of the target mean classifiers or regressor probably.
@solegalli solegalli added the new transformer New feature or request label Mar 26, 2022
@Morgan-Sell
Copy link
Collaborator

Hola @solegalli, how does this transformer from the TargetMeanRegressor that we created for feature selection?

@solegalli
Copy link
Collaborator Author

Actually it does not much in functionality. The TargetMeanRegressor is an estimator. We need to create a transformer instead, inheriting BaseEstimator and TrasformerMixin only. And then, we would not transform categorical variables, only numerical ones.

So it is a bit simpler. Give it a go if you fancy :)

@Morgan-Sell
Copy link
Collaborator

@solegalli,

Should the class have a binner_dict_ param similar to the AribitraryDiscretiser? If not, how will the transformer know which ranges to discretize?

@solegalli
Copy link
Collaborator Author

Same attributes as the other discretizers yes.

@Morgan-Sell Morgan-Sell linked a pull request Apr 16, 2022 that will close this issue
Open
@solegalli solegalli added the wontfix This will not be worked on label Jul 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
new transformer New feature or request wontfix This will not be worked on
Projects
None yet
Milestone
No milestone
2 participants
@Morgan-Sell @solegalli