Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to correct snippet range #156

Closed
xsuchy opened this issue Aug 16, 2024 · 3 comments · Fixed by #172
Closed

Ability to correct snippet range #156

xsuchy opened this issue Aug 16, 2024 · 3 comments · Fixed by #172
Assignees
Labels
documentation Improvements or additions to documentation

Comments

@xsuchy
Copy link
Member

xsuchy commented Aug 16, 2024

I can review the text of the snippet, but the range of the snippet in the log cannot be altered (and sometimes they are not visible too).

@FrostyX
Copy link
Member

FrostyX commented Aug 19, 2024

and sometimes they are not visible too

This will be fixed by #152

but the range of the snippet in the log cannot be altered

Though doable, I cannot think of a UI that would be easy to understand and easy to implement, so I am afraid this will be a WONTFIX with a documentation workaround (downvote the wrong snippet, create a new one correctly).

Or do you have some design in mind?

@TomasTomecek
Copy link
Collaborator

and sometimes they are not visible too

This will be fixed by #152

I just went through a few reviews and I can still reach snippets that are not visible in the log. I will look into this more.

@praiskup praiskup added the documentation Improvements or additions to documentation label Aug 21, 2024
@praiskup praiskup moved this from In 3 months to In Progress in CPT Kanban Aug 26, 2024
@FrostyX
Copy link
Member

FrostyX commented Aug 28, 2024

downvote the wrong snippet, create a new one correctly

This will work if the snippet is in an entirely different place but it won't work if you want to make an existing selection smaller or larger because we don't allow creating snippets over other snippets because it would be too hard to implement (I can explain the problems it causes on a meeting or here if you want to).

So I am not sure how to proceed with this ticket.

FrostyX added a commit to FrostyX/log-detective-website that referenced this issue Sep 24, 2024
See fedora-copr#156

This will be useful for changing a location of a snippet, in case the
new snippet should be over the previous one.
FrostyX added a commit to FrostyX/log-detective-website that referenced this issue Sep 24, 2024
See fedora-copr#156

This will be useful for changing a location of a snippet, in case the
new snippet should be over the previous one.
FrostyX added a commit to FrostyX/log-detective-website that referenced this issue Sep 25, 2024
See fedora-copr#156

This will be useful for changing a location of a snippet, in case the
new snippet should be over the previous one.
nikromen pushed a commit that referenced this issue Sep 30, 2024
See #156

This will be useful for changing a location of a snippet, in case the
new snippet should be over the previous one.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants