Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some snippets are not rendered #166

Closed
FrostyX opened this issue Sep 6, 2024 · 1 comment
Closed

Some snippets are not rendered #166

FrostyX opened this issue Sep 6, 2024 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@FrostyX
Copy link
Member

FrostyX commented Sep 6, 2024

As reported by @xsuchy some snippets are not visible. For example here https://logdetective.com/review/1710414808

@FrostyX FrostyX added the bug Something isn't working label Sep 6, 2024
@github-project-automation github-project-automation bot moved this to Needs triage in CPT Kanban Sep 6, 2024
@FrostyX
Copy link
Member Author

FrostyX commented Sep 6, 2024

The snippet range is in fact correct. In our data:

>>> data["logs"]["builder-live.log"]["snippets"]
[{'start_index': 258090,
  'end_index': 258229,
  'user_comment': 'object not declared in this scope'}]

>>> data["logs"]["builder-live.log"]["content"][258090:258229]
'\n../../designer/pluginloader.cpp:146:17: error: â\x80\x98Py_SetProgramNameâ\x80\x99 was not declared in this scope; did you mean â\x80\x98Py_GetProgramNameâ\x80'

The text is visible in the rendered log file. Only the snippet highlight isn't properly rendered around it.

FrostyX added a commit to FrostyX/log-detective-website that referenced this issue Sep 7, 2024
Fix fedora-copr#166

The `partition` function takes only doesn't include partitions with
fewer items than `n`. Therefore when we have an odd number of
snippets, the last one was not being highlighted.
@praiskup praiskup moved this from Needs triage to In Progress in CPT Kanban Sep 11, 2024
FrostyX added a commit to FrostyX/log-detective-website that referenced this issue Sep 15, 2024
Fix fedora-copr#166

The `partition` function takes only doesn't include partitions with
fewer items than `n`. Therefore when we have an odd number of
snippets, the last one was not being highlighted.
@nikromen nikromen moved this from In Progress to Done in CPT Kanban Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

No branches or pull requests

1 participant