Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: color coding per site in request logger #191

Merged

Conversation

almereyda
Copy link
Contributor

@almereyda almereyda commented Jul 9, 2024

This is the first half of the implementation of #190 proposed by Ward.

This mingles three StackOverflow answers and converts them to CoffeeScript.

It will colour requests in regular and in farm mode. Both escape the hostname. Eventually we will want to consider removing the :vhost token from the logger in regular single-site wikis.

addresses #190

@almereyda
Copy link
Contributor Author

Proof:

grafik

@almereyda
Copy link
Contributor Author

Please let me know if this meets our coding standards. I have the intuition that the colorString method could be refactored to live in some other place and be imported as a module from there.

If this is supposed to be a plugin, I can also try to rework it.

@paul90
Copy link
Member

paul90 commented Jul 23, 2024

Looks good. Thanks.

@paul90 paul90 merged commit 7397701 into fedwiki:master Jul 23, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants