Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settle on a convention for crates that are Spin CLI specific #2832

Open
calebschoepp opened this issue Sep 13, 2024 · 5 comments
Open

Settle on a convention for crates that are Spin CLI specific #2832

calebschoepp opened this issue Sep 13, 2024 · 5 comments

Comments

@calebschoepp
Copy link
Collaborator

We have a number of crates that are relevant to only the Spin CLI and it would be nice to have a naming convention to easily pick them out. One example is the sqlite crate which only deals with Spin CLI specific runtime configuration toml parsing. It would be nice if it were clear from the name of the crate that that was the case.

@lann
Copy link
Collaborator

lann commented Sep 16, 2024

Somewhere or other I suggested a spin-up- prefix for crates that only apply to the spin up runtime. I guess that is arguably different than "CLI-specific", but I think it would apply to the sqlite example anyway.

@calebschoepp
Copy link
Collaborator Author

What about spin-cli- prefix given that it applies to things like spin watch too?

@itowlson
Copy link
Contributor

@calebschoepp at the moment, watch isn't a crate, but a module in the spin-cli crate.

@calebschoepp
Copy link
Collaborator Author

@calebschoepp at the moment, watch isn't a crate, but a module in the spin-cli crate.

Thanks for clarifying Ivan. I'm just trying to demonstrate that the scope of a crate like this is broader than just spin up but rather is relevant to the entire Spin CLI.

@itowlson
Copy link
Contributor

Doh! Sorry Caleb, I misread your comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants