chore(cli): @fern-api/openapi-ir-parser conditionally imports swagger2openapi #5344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the
@fern-api/openapi-ir-parserpackage to conditionally import the swagger2openapi package, which brings in a variety of browser-incompatible dependencies. The solution is similar to the one done forprettierhere.This is a simple solution for now, but it prevents supporting Swagger 2.0 in the browser. Moving forward, we could split out the functionality we need from
swagger2openapi(i.e. just the convertObj method and its transitive closure), and make it browser compatible, but this at least gets us in a position where we support the browser use cases at hand.