Refactoring #71
Refactoring #71
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #71 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 2 2
Lines 97 97
=========================================
Hits 97 97 ☔ View full report in Codecov by Sentry. |
README.md
Outdated
| @@ -10,8 +10,6 @@ European Soccer Standings Module for MagicMirror² | |||
|
|
|||
| * An installation of [MagicMirror²](https://github.com/MichMich/MagicMirror) | |||
There was a problem hiding this comment.
Update the URL to https://github.com/MagicMirrorOrg/MagicMirror.
node_helper.js
Outdated
| * @external node-fetch | ||
| * @see https://www.npmjs.com/package/node-fetch | ||
| * @external logger | ||
| * @see https://github.com/MichMich/MagicMirror/blob/master/js/logger.js |
There was a problem hiding this comment.
Update the URL to https://github.com/MagicMirrorOrg/MagicMirror/blob/master/js/logger.js
package.json
Outdated
| "la liga", | ||
| "ligue 1", | ||
| "eredivisie", | ||
| "primeira liga" |
There was a problem hiding this comment.
On the new module list we are using sport like a main category. So it would be nice if you add it as keyword.
|
I hope it's okay that I've taken the opportunity to add a few comments. |
[Unreleased]
Requires version >= 18 of NodeJS!
Fixed
Added
Changed
loggerinstead ofconsoleRemoved