Support BACnet devices on nonstandard ports #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adam-nielsen
force-pushed
the
port-fix
branch
from
a28bcad
to
7b6c618
Compare
|
Updated branch to sync with latest master |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When communicating with other BACnet devices on the same machine, different ports must be used to ensure communications go to the right instance.
The outgoing messages were being sent on the standard BACnet UDP port, instead of going out to the same port they arrived from, making communications with nonstandard devices impossible.
This small patch includes the port number in the address field if it is nonstandard, fixing the issue.
I have tested this both with listening on port 47809 and talking to a device on port 47809, rather than the usual port 47808.