Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wrong formula of orientation feature in documentation? #64

Open
AEttinger opened this issue Apr 15, 2021 · 2 comments
Open

wrong formula of orientation feature in documentation? #64

AEttinger opened this issue Apr 15, 2021 · 2 comments
Assignees

Comments

@AEttinger
Copy link

Hello,

I'm currently trying to re-implement some of the Weka features in Python and had trouble to reproduce the orientation feature based on the Hessian matrix. After some digging, I found that the formula on the documentation page [ 1/2 arccos(4b^2 + (a - d)^2) ] does not match the one used in FeatureStack.java [ -0.5 * Math.acos((s_xx - s_yy) / Math.sqrt(4.0 * s_xy * s_xy + (s_xx - s_yy) * (s_xx - s_yy))) ]. Using the Feature Stack implementation, my result is now much more comparable to the output of the Weka plugin in Fiji, so I assume that this is being used.
I wanted to bring this to your attention, just in case somebody else stumbles over this. It may be good to change it on the documentation page.

Thank you very much.
Andreas

@ctrueden
Copy link
Member

Thanks, @AEttinger! What do you think, @iarganda?

@iarganda
Copy link
Collaborator

Hey @ctrueden and @AEttinger ! Sorry to come late to the conversation. If I'm not mistaken, someone else told me about it before. I tried to update the TWS site, but at the time it was not possible because of the transition of the imagej.net site. Is it possible now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants