-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rethink "message context" #1151
Comments
I would personally prefer to split into multiple parts. |
Alternatively, find some way to embed this contextual information in the actor when instantiating it. |
Basically, think about forward compatibility and performance. |
Alternative: split these contexts back up into individual functions (e.g., We moved away from this approach for performance reasons (crossing the syscall boundary was expensive) but we may be able to avoid all of this without crossing the syscall boundary if we:
The benefit of this approach is that:
|
Ok, so, we'd likely want to bundle these all into a single wasm module which means removing all the namespacing we have on the current APIs. I.e., we currently have methods like |
Ah HA! Ok, we don't even need to do this at runtime. We can:
This lets us reduce the API surface to just "import these wasm globals". |
While exploring this issue, we decided it likely wasn't the right approach. See #1908 for the current thinking. |
We currently have a syscalls to lookup a message context and a network context where:
However, the "message" context is a bit funky because it includes the origin, gas premium, and gas limit. Really, its a mix of message specific information and "invocation context" related things.
We should consider either splitting it up into multiple parts, or renaming it back to
InvocationContext
.The text was updated successfully, but these errors were encountered: