-
-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Low performance when working with requests returning higher weight of data #106
Comments
@filiphric First, thank you for such an awesome plugin! Love using it. Second, I do run into this as well. I'm getting back data at speeds of 7 seconds when using cy.api(). Using cy.request() returns in 630ms. It seems to do with the size of the data. One particular command gets back data with the length of 12,314 items (body.length). Seems to do with actually rendering the actual response data. Perhaps limiting what is shown at first might be an answer? If it is all shown, have an expand that finishes the data? |
@filiphric firstly also thank you for this amazing plugin, it is a pity that I had to disable it for the same reason reported above. I have some tests containing 50 API calls, some of which have pretty big response payloads. When adding this plugin cypress slows down a lot and most of the time it crashes. I investigated this a little bit and it is clearly a memory consumption issue. Just to give an example, when running a specific spec file I tested with, the Google Chrome Helper (Renderer) process had the following memory consumption when debugging using
This could be happening due to a memory leak. I had a look at the code to try and find out what could be the culprit of this memory consumption and after some trial and error changes I found out that when commenting out the Prism library syntax highlighting here and suddenly the tests where running a lot faster with a lot less memory consumption:
So one easy way of significantly lowering the likeliness of this problem is to introduce an option to disable syntax highlighting altogether. It is a nice feature, but I would be more than happy to do without it if it means that I would be able to benefit from the rest of the features of this plugin 😄 - and the result isn't that bad: 2GB of memory is still a bit on the high side when compared to 700-800mb of memory when using cy.request() but at least it would make this plugin useable in scenarios where a lot of API calls with large payloads are needed. One other factor which might be contributing to memory consumption (haven't tested this) is the fact that a lot of mounting and unmounting of the of the Vue app is happening especially when a test has a lot of API calls (even more with An alterative (and possibly neater) way to approach this (not sure about this as I am not familiar with nuances and limitations of cypress plugins) could be to mount the Vue app once and feed additions to the props data per API call through a redux store (using action dispatches) and the app will reactively update the plugin UI when the store data updates. The same way could be used to avoid unmounting the app in case of Hope this helps in solving this issue quicker 😃 - and again thank you for making a lot of E2E engineers' lives a lot simpler with this intuitive plugin. |
I noticed that using the plugin to send get request which responds with JSON of weight 298KB causes Cypress Test Runner to crash later in the test when run headed:
When run headlessly the test lasts 03:10 min:
When changed
cy.api()
tocy.request()
the test lasts 0:30 min:The text was updated successfully, but these errors were encountered: