Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(downsample): use jackson to serialize exported labels #1679

Merged
merged 1 commit into from
Oct 2, 2023
Merged

fix(downsample): use jackson to serialize exported labels #1679

merged 1 commit into from
Oct 2, 2023

Conversation

alextheimer
Copy link
Contributor

Pull Request checklist

  • The commit(s) message(s) follows the contribution guidelines ?
  • Tests for the changes have been added (for bug fixes / features) ?
  • Docs have been added / updated (for bug fixes / features) ?

Currently, the BatchExporter might serialize certain edge-case label-value pairs into invalid JSON. This PR replaces the custom serialization logic with jackson.

kvpetrov
kvpetrov approved these changes Oct 2, 2023
View reviewed changes
Copy link
Contributor

@kvpetrov kvpetrov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

yu-shipit
yu-shipit approved these changes Oct 2, 2023
View reviewed changes
Copy link
Contributor

@yu-shipit yu-shipit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgmt

@alextheimer alextheimer merged commit bcc124b into filodb:develop Oct 2, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yu-shipit yu-shipit yu-shipit approved these changes

@kvpetrov kvpetrov kvpetrov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alextheimer @kvpetrov @yu-shipit