This repository has been archived by the owner on Sep 18, 2023. It is now read-only.
Activity names issue #6
Malicious1
started this conversation in
Ideas
Replies: 2 comments
-
This was how I thought I implemented it but I may have missed it. Thanks for alerting me. |
Beta Was this translation helpful? Give feedback.
0 replies
-
I filed an issue #11 This is definitely something that needs to be resolved. Thank you for reporting it. |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
Hi,
I've found some issues regarding naming of activities (
activtyType.name
attribute). On the workflow side it is inferred fromActivityInterfaceClassName::method_name
or you can give it a custom name by means of thename
parameter of theactivity_method
decorator, thats all fine.Unfortunately on the activity side (
register_activities_implementation
) you have very little room for setting the activityType and the two::
are always there. So consider integration with a workflow code written in Java - you have to anticipate this issue and explicitly rename the activity interface so that it fits this convention. Have you considered allowing for passing the activityType.name directly toregister_activities_implementation
? Or maybe it is possible to somehow make use of thename
param passed via theactivity_method
decorator (one would expect to inherit ActivitiesImplementation from ActivitiesInterface anyway right)?Beta Was this translation helpful? Give feedback.
All reactions