-
Notifications
You must be signed in to change notification settings - Fork 578
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjust Functions getters to be Kotlin source compatible #6530
base: main
Are you sure you want to change the base?
Conversation
Javadoc Changes:--- /home/runner/diff/original/firebase-kotlindoc/android/com/google/firebase/functions/HttpsCallableResult.html 2024-11-22 21:17:35.776847438 +0000
+++ /home/runner/diff/modified/firebase-kotlindoc/android/com/google/firebase/functions/HttpsCallableResult.html 2024-11-22 21:15:07.552989456 +0000
@@ -21,26 +21,26 @@
</colgroup>
<thead>
<tr>
- <th colspan="100%"><h3>Public methods</h3></th>
+ <th colspan="100%"><h3>Public fields</h3></th>
</tr>
</thead>
<tbody class="list">
<tr>
<td><code>final <a href="https://developer.android.com/reference/kotlin/java/lang/Object.html">Object</a></code></td>
<td>
- <div><code><a href="/docs/reference/android/com/google/firebase/functions/HttpsCallableResult.html#getData()">getData</a>()</code></div>
- <p>Returns the data that was returned from the Callable HTTPS trigger.</p>
+ <div><code><a href="/docs/reference/android/com/google/firebase/functions/HttpsCallableResult.html#data()">data</a></code></div>
+ <p>The data that was returned from the Callable HTTPS trigger.</p>
</td>
</tr>
</tbody>
</table>
</div>
<div class="list">
- <h2>Public methods</h2>
- <div class="api-item"><a name="getData--"></a><a name="getdata"></a>
- <h3 class="api-name" id="getData()">getData</h3>
- <pre class="api-signature no-pretty-print">public final <a href="https://developer.android.com/reference/kotlin/java/lang/Object.html">Object</a> <a href="/docs/reference/android/com/google/firebase/functions/HttpsCallableResult.html#getData()">getData</a>()</pre>
- <p>Returns the data that was returned from the Callable HTTPS trigger.</p>
+ <h2>Public fields</h2>
+ <div class="api-item"><a name="getData()"></a><a name="setData()"></a><a name="getData--"></a><a name="setData--"></a>
+ <h3 class="api-name" id="data()">data</h3>
+ <pre class="api-signature no-pretty-print">public final <a href="https://developer.android.com/reference/kotlin/java/lang/Object.html">Object</a> <a href="/docs/reference/android/com/google/firebase/functions/HttpsCallableResult.html#data()">data</a></pre>
+ <p>The data that was returned from the Callable HTTPS trigger.</p>
<p>The data is in the form of native Java objects. For example, if your trigger returned an array, this object would be a List<Object>. If your trigger returned a JavaScript object with keys and values, this object would be a Map.</p>
</div>
</div> --- /home/runner/diff/original/firebase-kotlindoc/kotlin/com/google/firebase/functions/HttpsCallableResult.html 2024-11-22 21:17:35.764847437 +0000
+++ /home/runner/diff/modified/firebase-kotlindoc/kotlin/com/google/firebase/functions/HttpsCallableResult.html 2024-11-22 21:15:07.548989459 +0000
@@ -21,26 +21,26 @@
</colgroup>
<thead>
<tr>
- <th colspan="100%"><h3>Public functions</h3></th>
+ <th colspan="100%"><h3>Public properties</h3></th>
</tr>
</thead>
<tbody class="list">
<tr>
<td><code><a href="https://kotlinlang.org/api/latest/jvm/stdlib/kotlin/-any/index.html">Any</a>?</code></td>
<td>
- <div><code><a href="/docs/reference/kotlin/com/google/firebase/functions/HttpsCallableResult.html#getData()">getData</a>()</code></div>
- <p>Returns the data that was returned from the Callable HTTPS trigger.</p>
+ <div><code><a href="/docs/reference/kotlin/com/google/firebase/functions/HttpsCallableResult.html#data()">data</a></code></div>
+ <p>The data that was returned from the Callable HTTPS trigger.</p>
</td>
</tr>
</tbody>
</table>
</div>
<div class="list">
- <h2>Public functions</h2>
- <div class="api-item"><a name="getData--"></a><a name="getdata"></a>
- <h3 class="api-name" id="getData()">getData</h3>
- <pre class="api-signature no-pretty-print">fun <a href="/docs/reference/kotlin/com/google/firebase/functions/HttpsCallableResult.html#getData()">getData</a>(): <a href="https://kotlinlang.org/api/latest/jvm/stdlib/kotlin/-any/index.html">Any</a>?</pre>
- <p>Returns the data that was returned from the Callable HTTPS trigger.</p>
+ <h2>Public properties</h2>
+ <div class="api-item"><a name="getData()"></a><a name="setData()"></a><a name="getData--"></a><a name="setData--"></a>
+ <h3 class="api-name" id="data()">data</h3>
+ <pre class="api-signature no-pretty-print">val <a href="/docs/reference/kotlin/com/google/firebase/functions/HttpsCallableResult.html#data()">data</a>: <a href="https://kotlinlang.org/api/latest/jvm/stdlib/kotlin/-any/index.html">Any</a>?</pre>
+ <p>The data that was returned from the Callable HTTPS trigger.</p>
<p>The data is in the form of native Java objects. For example, if your trigger returned an array, this object would be a List<Object>. If your trigger returned a JavaScript object with keys and values, this object would be a Map.</p>
</div>
</div> |
Vertex AI Mock Responses Check
|
Generated by 🚫 Danger |
Coverage Report 1Affected ProductsTest Logs |
Test Results20 files - 1 016 20 suites - 1 016 33s ⏱️ - 36m 13s Results for commit 918de3a. ± Comparison against base commit f1c75df. This pull request removes 5850 tests.
|
Size Report 1Affected Products
Test Logs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just need to fix the instrumentation tests
Also, please reference #6522 |
No description provided.