Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust Functions getters to be Kotlin source compatible #6530

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

emilypgoogle
Copy link
Collaborator

No description provided.

Copy link
Contributor

github-actions bot commented Nov 22, 2024

Javadoc Changes:
--- /home/runner/diff/original/firebase-kotlindoc/android/com/google/firebase/functions/HttpsCallableResult.html	2024-11-22 21:17:35.776847438 +0000
+++ /home/runner/diff/modified/firebase-kotlindoc/android/com/google/firebase/functions/HttpsCallableResult.html	2024-11-22 21:15:07.552989456 +0000
@@ -21,26 +21,26 @@
         </colgroup>
         <thead>
           <tr>
-            <th colspan="100%"><h3>Public methods</h3></th>
+            <th colspan="100%"><h3>Public fields</h3></th>
           </tr>
         </thead>
         <tbody class="list">
           <tr>
             <td><code>final <a href="https://developer.android.com/reference/kotlin/java/lang/Object.html">Object</a></code></td>
             <td>
-              <div><code><a href="/docs/reference/android/com/google/firebase/functions/HttpsCallableResult.html#getData()">getData</a>()</code></div>
-              <p>Returns the data that was returned from the Callable HTTPS trigger.</p>
+              <div><code><a href="/docs/reference/android/com/google/firebase/functions/HttpsCallableResult.html#data()">data</a></code></div>
+              <p>The data that was returned from the Callable HTTPS trigger.</p>
             </td>
           </tr>
         </tbody>
       </table>
     </div>
     <div class="list">
-      <h2>Public methods</h2>
-      <div class="api-item"><a name="getData--"></a><a name="getdata"></a>
-        <h3 class="api-name" id="getData()">getData</h3>
-        <pre class="api-signature no-pretty-print">public&nbsp;final&nbsp;<a href="https://developer.android.com/reference/kotlin/java/lang/Object.html">Object</a>&nbsp;<a href="/docs/reference/android/com/google/firebase/functions/HttpsCallableResult.html#getData()">getData</a>()</pre>
-        <p>Returns the data that was returned from the Callable HTTPS trigger.</p>
+      <h2>Public fields</h2>
+      <div class="api-item"><a name="getData()"></a><a name="setData()"></a><a name="getData--"></a><a name="setData--"></a>
+        <h3 class="api-name" id="data()">data</h3>
+        <pre class="api-signature no-pretty-print">public&nbsp;final&nbsp;<a href="https://developer.android.com/reference/kotlin/java/lang/Object.html">Object</a>&nbsp;<a href="/docs/reference/android/com/google/firebase/functions/HttpsCallableResult.html#data()">data</a></pre>
+        <p>The data that was returned from the Callable HTTPS trigger.</p>
         <p>The data is in the form of native Java objects. For example, if your trigger returned an array, this object would be a List<Object>. If your trigger returned a JavaScript object with keys and values, this object would be a Map.</p>
       </div>
     </div>
--- /home/runner/diff/original/firebase-kotlindoc/kotlin/com/google/firebase/functions/HttpsCallableResult.html	2024-11-22 21:17:35.764847437 +0000
+++ /home/runner/diff/modified/firebase-kotlindoc/kotlin/com/google/firebase/functions/HttpsCallableResult.html	2024-11-22 21:15:07.548989459 +0000
@@ -21,26 +21,26 @@
         </colgroup>
         <thead>
           <tr>
-            <th colspan="100%"><h3>Public functions</h3></th>
+            <th colspan="100%"><h3>Public properties</h3></th>
           </tr>
         </thead>
         <tbody class="list">
           <tr>
             <td><code><a href="https://kotlinlang.org/api/latest/jvm/stdlib/kotlin/-any/index.html">Any</a>?</code></td>
             <td>
-              <div><code><a href="/docs/reference/kotlin/com/google/firebase/functions/HttpsCallableResult.html#getData()">getData</a>()</code></div>
-              <p>Returns the data that was returned from the Callable HTTPS trigger.</p>
+              <div><code><a href="/docs/reference/kotlin/com/google/firebase/functions/HttpsCallableResult.html#data()">data</a></code></div>
+              <p>The data that was returned from the Callable HTTPS trigger.</p>
             </td>
           </tr>
         </tbody>
       </table>
     </div>
     <div class="list">
-      <h2>Public functions</h2>
-      <div class="api-item"><a name="getData--"></a><a name="getdata"></a>
-        <h3 class="api-name" id="getData()">getData</h3>
-        <pre class="api-signature no-pretty-print">fun&nbsp;<a href="/docs/reference/kotlin/com/google/firebase/functions/HttpsCallableResult.html#getData()">getData</a>():&nbsp;<a href="https://kotlinlang.org/api/latest/jvm/stdlib/kotlin/-any/index.html">Any</a>?</pre>
-        <p>Returns the data that was returned from the Callable HTTPS trigger.</p>
+      <h2>Public properties</h2>
+      <div class="api-item"><a name="getData()"></a><a name="setData()"></a><a name="getData--"></a><a name="setData--"></a>
+        <h3 class="api-name" id="data()">data</h3>
+        <pre class="api-signature no-pretty-print">val&nbsp;<a href="/docs/reference/kotlin/com/google/firebase/functions/HttpsCallableResult.html#data()">data</a>:&nbsp;<a href="https://kotlinlang.org/api/latest/jvm/stdlib/kotlin/-any/index.html">Any</a>?</pre>
+        <p>The data that was returned from the Callable HTTPS trigger.</p>
         <p>The data is in the form of native Java objects. For example, if your trigger returned an array, this object would be a List<Object>. If your trigger returned a JavaScript object with keys and values, this object would be a Map.</p>
       </div>
     </div>

Copy link
Contributor

Vertex AI Mock Responses Check ⚠️

A newer major version of the mock responses for Vertex AI unit tests is available. update_responses.sh should be updated to clone the latest version of the responses: v5.2

@google-oss-bot
Copy link
Contributor

1 Warning
⚠️ Did you forget to add a changelog entry? (Add the 'no-changelog' label to the PR to silence this warning.)

Generated by 🚫 Danger

@google-oss-bot
Copy link
Contributor

Copy link
Contributor

Test Results

20 files   -  1 016  20 suites   - 1 016   33s ⏱️ - 36m 13s
23 tests  -  5 850  23 ✅  -  5 828  0 💤  - 22  0 ❌ ±0 
68 runs   - 11 763  68 ✅  - 11 719  0 💤  - 44  0 ❌ ±0 

Results for commit 918de3a. ± Comparison against base commit f1c75df.

This pull request removes 5850 tests.
com.google.android.datatransport.cct.CctBackendFactoryTest ‑ create_returnCCTBackend_WhenBackendNameIsCCT
com.google.android.datatransport.cct.CctDestinationTest ‑ cctDestination_shouldOnlySupportProtoAndJson
com.google.android.datatransport.cct.CctDestinationTest ‑ cctDestination_shouldSupportProtoAndJson
com.google.android.datatransport.cct.CctTransportBackendTest ‑ decorate_whenOffline_shouldProperlyPopulateNetworkInfo
com.google.android.datatransport.cct.CctTransportBackendTest ‑ decorate_whenOnline_shouldProperlyPopulateNetworkInfo
com.google.android.datatransport.cct.CctTransportBackendTest ‑ schedule_shouldAddCookieOnPseudonymousIds
com.google.android.datatransport.cct.CctTransportBackendTest ‑ schedule_shouldDropCookieOnMixedPseudonymousIds
com.google.android.datatransport.cct.CctTransportBackendTest ‑ send_CompressedResponseIsUncompressed
com.google.android.datatransport.cct.CctTransportBackendTest ‑ send_whenBackendRedirectsMoreThan5Times_shouldOnlyRedirect4Times
com.google.android.datatransport.cct.CctTransportBackendTest ‑ send_whenBackendRedirects_shouldCorrectlyFollowTheRedirectViaPost
…

@google-oss-bot
Copy link
Contributor

Size Report 1

Affected Products

  • firebase-functions

    TypeBase (f1c75df)Merge (0a90e6e)Diff
    aar65.9 kB65.9 kB-2 B (-0.0%)
    apk (release)5.44 MB5.44 MB-8 B (-0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/4wr368hthu.html

Copy link
Collaborator

@rlazo rlazo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just need to fix the instrumentation tests

@rlazo
Copy link
Collaborator

rlazo commented Nov 23, 2024

Also, please reference #6522

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants