From 8de7b09f571772652408e09f9d2e2dc9c8426b83 Mon Sep 17 00:00:00 2001 From: Patrick Roy Date: Mon, 9 Oct 2023 16:25:10 +0100 Subject: [PATCH] Remove redundant min-version check from artifacts.py With the new CI artifacts system, we no longer keep all firecracker releases in a single S3 bucket, and instead keep a folder of supported firecracker releases per artifacts folder. This means that in the 1.6 artifacts folder, only 1.4 and 1.5 release binaries exist. Therefore, the additional check in firecracker_artifacts() is no longer needed. We remove it, because it specifies the minimal version as a tuple, and is thus easily missed when doign a release (as the runbook only hints that sometimes min-versions are specified as strings). Signed-off-by: Patrick Roy --- tests/framework/artifacts.py | 3 --- 1 file changed, 3 deletions(-) diff --git a/tests/framework/artifacts.py b/tests/framework/artifacts.py index a2e35da39fe..be91a0421ce 100644 --- a/tests/framework/artifacts.py +++ b/tests/framework/artifacts.py @@ -123,7 +123,6 @@ def firecracker_artifacts(): cargo_version = get_firecracker_version_from_toml() # until the next minor version (but *not* including) max_version = (cargo_version.major, cargo_version.minor + 1, 0) - min_version = (1, 3, 0) prefix = "firecracker/firecracker-*" for firecracker in sorted(ARTIFACT_DIR.glob(prefix)): match = re.match(r"firecracker-v(\d+)\.(\d+)\.(\d+)", firecracker.name) @@ -131,8 +130,6 @@ def firecracker_artifacts(): continue fc = FirecrackerArtifact(firecracker) version = fc.version_tuple - if version < min_version: - continue if version >= max_version: continue yield pytest.param(fc, id=fc.name)