Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unnecessary packet copy in fd_quic_tile #3460

Open
ripatel-fd opened this issue Nov 16, 2024 · 1 comment
Open

Unnecessary packet copy in fd_quic_tile #3460

ripatel-fd opened this issue Nov 16, 2024 · 1 comment
Assignees
@ripatel-fd
Labels
perf Performance optimization quic RFC 9000: QUIC

Comments

@ripatel-fd
Copy link
Contributor

firedancer/src/app/fdctl/run/tiles/fd_quic.c

Line 238 in 82822e4

fd_memcpy( ctx->buffer, src, sz ); /* TODO: Eliminate copy... fd_aio needs refactoring */

This copy is practically redundant.
We can do decryption in during_frag. An overrun would appear as a decryption failure.
@ripatel-fd ripatel-fd added quic RFC 9000: QUIC perf Performance optimization labels Nov 16, 2024
@ripatel-fd
Copy link
Contributor Author

@mmcgee-jump Thoughts?

@ripatel-fd ripatel-fd self-assigned this Nov 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ripatel-fd ripatel-fd

Labels
perf Performance optimization quic RFC 9000: QUIC
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ripatel-fd