Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sigverify Edge Cases #40

Open
ripatel-fd opened this issue Oct 6, 2022 · 1 comment
Open

Sigverify Edge Cases #40

ripatel-fd opened this issue Oct 6, 2022 · 1 comment

Comments

@ripatel-fd
Copy link
Contributor

Can we be sure that crypto/ed25519 performs exactly the same malleability checks as ed25519-dalek verify_strict?

https://hdevalence.ca/blog/2020-10-04-its-25519am

We should probably add test fixtures for edge cases.

@leoluk
Copy link
Collaborator

leoluk commented Oct 7, 2022

According to the post, this Go package does malleability checks: https://github.com/hdevalence/ed25519consensus

Haven't found any information on what the current status of the stdlib implementation is.

I'm not sure if it actually matters for transaction verification outside of consensus use cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants