Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEVC "GAUGE HEAT FLUX GAS" #13866

Open
rupole1185 opened this issue Dec 10, 2024 · 10 comments
Open

DEVC "GAUGE HEAT FLUX GAS" #13866

rupole1185 opened this issue Dec 10, 2024 · 10 comments
Assignees

Comments

@rupole1185
Copy link

Describe the bug
The following fds simulation has a two different behaviour: if the DEVC "GAUGE HEAT FLUX GAS" are present in the file the simulation is about 50% slower than the same simulation without these devices

To Reproduce
Run the analysis with and without the DEVC "GAUGE HEAT FLUX GAS" on FDS 6.9.1 and FDS nighly

Expected behavior
I wonder if such a slow down is normal or it could be reduced. What I notice is the CPU usage decreases with time in the simulation with DEVC, while it does not decreas with time without DEVC
image

Desktop (please complete the following information):

  • Version: FDS 6.9.1 and nightly

TestGAUGE_TestGAUGE_Cleaned.fds.txt

@Er9y714
Copy link

Er9y714 commented Dec 11, 2024

Did you compare the timestep and number of iterations?

@rupole1185
Copy link
Author

rupole1185 commented Dec 11, 2024

In two example I have made I noticed that they got to 900 iterations (46.38s) in just two different time.
With the gauge it took it about 30 minutes, with without it it took approximately 15 minutes.

Time step number and simulation time seems not to change between the two cases, it is just the computational time to get there which is higher

@mcgratta mcgratta self-assigned this Dec 11, 2024
@mcgratta
Copy link
Contributor

I cannot run the case. There are vents that are not attached to any surface.

ERROR(820): VENT West Test Exhaust_01 has no solid backing or an orientation index (IOR) is needed. (MPI Process: 7, CHID: Test_GaugeDevice_with)

@rupole1185
Copy link
Author

Hi Kevin,

yeah sorry, you have to remove the following 6 vents:

image

Beside that, I have retested it with today's nightly and still the slow down when GAUGE devices are present is measurable. The simulations are about 20% slower with these devices.

@mcgratta
Copy link
Contributor

OK, I'll run the cases. My first guess is that by using these "_GAS" devices, you are creating some overhead having to do with particles. Any "_GAS' device is a particle that records information.

@drjfloyd
Copy link
Contributor

In read at 5792 we have:

IF (TARGET_ONLY) THEN
...
SOLID_PARTICLES = .TRUE.
...
ENDIF

Should we be setting SOLID_PARTICLES=T here? This causes us to evaluate particle interactions with radiation, but a TARGET_ONLY particle isn't meant to exchange energy with the gas, just be able to record data. However, the amount of extra code tied to this doesn't look like enough though to give a 20+ % change.

I deleted all but the OPEN VENTs and ran for 10 s with and without particles on our cluster and the runtimes were 526 (no particles) and 543 (with particles) or 3.3 % slower. Ran for 30 s and results were 1542 and 1556 or 0.9 % slower.

@mcgratta
Copy link
Contributor

mcgratta commented Dec 16, 2024

I ran the case for 100 s. The CPU usage was 5288 s for the case with the heat flux devices and 5247 s without.

image

The extra 40 s was spent mainly in the radiation and output routines. This is not too surprising. Memory usage is about the same

image

@mcgratta
Copy link
Contributor

By the way, you can see the timings of the major subroutines in the file job_name_cpu.csv

@mcgratta
Copy link
Contributor

Could you post the _cpu.csv files for the cases that show a large difference in CPU time.

@rupole1185
Copy link
Author

rupole1185 commented Dec 24, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants