Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

boundary file interpolation looks off on GEOM terrain #2102

Open
ericvmueller opened this issue Dec 11, 2024 · 10 comments
Open

boundary file interpolation looks off on GEOM terrain #2102

ericvmueller opened this issue Dec 11, 2024 · 10 comments
Assignees

Comments

@ericvmueller
Copy link

Run the LS_ellipse_0ms_30deg.fds case and pull up the IGNITION TIME boundary file in smokeview. Clip the upper bound to something close to T_END (125 s).

It looks like the interpolation to the nodes is flipped in each patch or something
image

@mcgratta
Copy link
Contributor

Is this a Smokeview or FDS issue. Can you assign it.

@ericvmueller
Copy link
Author

ericvmueller commented Dec 11, 2024

Ah sorry, Glenn asked me to post it here so I will assign him for now.

Edit: or maybe I wont... I don't seem to have that power on this repo

@gforney gforney self-assigned this Dec 11, 2024
@gforney
Copy link
Contributor

gforney commented Dec 11, 2024

I assigned myself

@gforney
Copy link
Contributor

gforney commented Dec 11, 2024

marcos, are geometry boundary files node centered or cell centered?

@gforney
Copy link
Contributor

gforney commented Dec 11, 2024

smokeview is drawing geometry boundary files as if they are "cell" centered - that is coloring each triangle according to the value passed for that triangle

@ericvmueller
Copy link
Author

Is that the expected behavior, then? I'm not so familiar with GEOM boundary outputs ...and equally likely the appearance of an inverted color gradient with the cells is just my bad eyesight

@gforney
Copy link
Contributor

gforney commented Dec 11, 2024

smokeview is drawing the same color for each vertex in a triangle. I assume because fds is passing data to smokeview by triangle, one value for each triangle. marcos is there an option to pass values to smokeview by vertex?

@marcosvanella
Copy link
Contributor

cell_centered is set to true always in DUMP_BNDF. Not clear why as we have the option to do VERTEX writing in DUMP_SLICE_GEOM_DATA. Take a look in there in the code section:

! these two routines need to be moved and called only once
      CALL GET_GEOMINFO(SLICETYPE,I1,I2,J1,J2,K1,K2,NVERTS,NVERTS_CUTCELLS,NFACES,NFACES_CUTCELLS,VERTS,FACES,LOCATIONS)
      CALL MAKE_UNIQUE_VERT_ARRAY(VERTS, VERT_UNIQUE, NVERTS)
      CALL AVERAGE_FACE_VALUES(VERT_UNIQUE, VERT_VALS, NVERTS, FACES, VALS, NFACES)

@gforney
Copy link
Contributor

gforney commented Dec 19, 2024

@ericvmueller is this still and issue?

@ericvmueller
Copy link
Author

@marcosvanella and I were discussing whether we should allow CELL_CENTERED=F for GEOM boundary files. If we want to implement that maybe lets leave this open until its sorted out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants