Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup package.json #296

Open
jchris opened this issue Oct 14, 2024 · 3 comments
Open

cleanup package.json #296

jchris opened this issue Oct 14, 2024 · 3 comments

Comments

@jchris
Copy link
Contributor

jchris commented Oct 14, 2024

Currently we list React etc which we dont need / use

"react": "from-package-json",

It'd make auditing this a lot easier for 3rd parties.

@jchris
Copy link
Contributor Author

jchris commented Jan 3, 2025

this is still here:

"react": "^18.3.1",

@jchris
Copy link
Contributor Author

jchris commented Jan 3, 2025

is this still needed in core?

"react": "from-package-json"

@jchris
Copy link
Contributor Author

jchris commented Jan 3, 2025

I suggest removing the above references and switching this to the raw version number instead of referencing the root package.json -- unless there is a reason to have the peer-dependency number surfaced on the core package.json as a peer... not sure we need that

Code:

"react": "from-package-json",

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant