Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

app breaks because image-source was not properly imported #103

Open
ovaltechnologiesinc opened this issue Feb 5, 2022 · 1 comment
Open

Comments

@ovaltechnologiesinc
Copy link

Hi! 👋

Firstly, thanks for your work on this project! 🙂

Today I used patch-package to patch [email protected] for the project I'm working on.

Here is the diff that solved my problem:

diff --git a/node_modules/nativescript-contacts/contact-helper.android.js b/node_modules/nativescript-contacts/contact-helper.android.js
index 11d7474..cc346e3 100644
--- a/node_modules/nativescript-contacts/contact-helper.android.js
+++ b/node_modules/nativescript-contacts/contact-helper.android.js
@@ -1,6 +1,6 @@
 var appModule = require("@nativescript/core/application");
 var KnownLabel = require("./known-label");
-var imageSource = require("image-source");
+var imageSource = require('@nativescript/core/image-source');
 
 /* missing constants from the {N} */
 var TYPE_CUSTOM = 0;
diff --git a/node_modules/nativescript-contacts/platforms/android/nativescript_contacts.aar b/node_modules/nativescript-contacts/platforms/android/nativescript_contacts.aar
new file mode 100644
index 0000000..27f9619
Binary files /dev/null and b/node_modules/nativescript-contacts/platforms/android/nativescript_contacts.aar differ

This issue body was partially generated by patch-package.

@lewebsimple
Copy link

Can we get this merged please ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants