feat: Direct Gilrs integration #475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaxCWhitehead
approved these changes
Oct 6, 2024
There was a problem hiding this comment.
This looks good to me - I have not tested on Jumpy as I am behind on updating bones there - but that will be caught up soon. (But I did just dig my gamepad out of moving boxes heh).
Will open any issues if hit any in testing later - thanks for doing this, needed it for a while to hopefully fix: fishfolk/jumpy#989
This was referenced Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces being tied to bevy for gamepad support (which is on an old version). Directly imports and orchestrates Gilrs in bones itself, while fitting into the existing input flow to not cause any issues until keyboard/mouse are also brought into bones.