fix(input): Remove SendWrapper from GILRS_CONTEXT (unless on wasm) #477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you CI - I see I got this wrong, GilrContext needs to be sync/send and isn't on wasm. Maybe only SendWrapper on wasm? Bevy runs single threaded in this case. |
MaxCWhitehead
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't think we want SendWrapper here - this will panic if accessed from a different thread than it was initialized with, was panicking on start updating bones in jumpy. Bevy systems may be scheduled to other threads.
Arc + Mutex should make us sync + send here anyway. Lmk if any concerns with this @RockasMockas