You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Return result from document_mean_pooling and document_max_pooling functions.
Add unit tests for testing each cls pooling option.
Refactor test_default_embeddings_stay_the_same_after_saving_and_loading and test_embeddings_stay_the_same_after_saving_and_loading in BaseEmbeddingsTest to use torch.allclose
I thought that the two failing tests (test_default_embeddings_stay_the_same_after_saving_and_loading for TransformerWordEmbeddings and TransformerDocumentEmbeddings) were somehow due to my changes, but this doesn't seem to be the case.
When running tests locally, every test passes. Then I ran the ci.yml using act to simulate the CI job locally. I ran the act -j 'test' and got those tests to fail on master.
Looking at the output, the problem was in comparing the floating point values (tensors) with == instead of using something as torch.allclose.
I changed this == to use torch.allclose in both test_default_embeddings_stay_the_same_after_saving_and_loading and test_embeddings_stay_the_same_after_saving_and_loading.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
"cls"pooling option into a function.resultfromdocument_mean_poolinganddocument_max_poolingfunctions.test_default_embeddings_stay_the_same_after_saving_and_loadingandtest_embeddings_stay_the_same_after_saving_and_loadinginBaseEmbeddingsTestto usetorch.allcloseFixes #3552.