Fixes the incorrect token prediction distribution from _all_scores_for_token() in sequence_tagger_model.py #3449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mdmotaharmahtab thanks a lot for this PR! @whoisjones can you review? |
|
I have examined the failing unit tests and found that they also failed on the master branch (so rebasing on the master did not help). They may not be related to this PR. Do I need to work on these tests for this PR? @whoisjones @alanakbik |
helpmefindaname
force-pushed
the
fix_scores_for_token
branch
from
58ccd25
to
cc6c746
Compare
helpmefindaname
force-pushed
the
fix_scores_for_token
branch
from
cc6c746
to
a2f5a0a
Compare
|
Hello. Want to know if this PR will be reviewed any time soon? @whoisjones @alanakbik |
helpmefindaname
force-pushed
the
fix_scores_for_token
branch
from
a2f5a0a
to
a0b3ea6
Compare
helpmefindaname
approved these changes
Oct 11, 2024
helpmefindaname
force-pushed
the
fix_scores_for_token
branch
from
a0b3ea6
to
1a46c55
Compare
|
Should I rebase with main ? |
helpmefindaname
force-pushed
the
fix_scores_for_token
branch
from
1a46c55
to
1f831e0
Compare
|
Thank you for your contribution @mdmotaharmahtab |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the issue #3448 . Previously, due to incorrect length calculation for each sentence in the batch, the returned tag probability distribution for each token was incorrect (from the _all_scores_for_token() function in sequence_tagger_model.py). This PR makes a small change in _all_scores_for_token() function to correctly compute the length.