Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix bug if inner sub set is empty causing NPE [tentative] #48

Merged
merged 2 commits into from
Oct 20, 2024

Conversation

luanpotter
Copy link
Member

@luanpotter luanpotter commented Oct 17, 2024

(I haven't tried but I think this might be the issue)

Tries to fix flame-engine/flame#3347 (needs to validate)

(I haven't tried but I think this might be the issue)
@luanpotter luanpotter changed the title Fix bug if inner sub set is empty causing NPE [tentative] fix: Fix bug if inner sub set is empty causing NPE [tentative] Oct 17, 2024
lib/ordered_set.dart Outdated Show resolved Hide resolved
@coveralls
Copy link

Pull Request Test Coverage Report for Build 11388053958

Details

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 97.345%

Totals Coverage Status
Change from base Build 10766990276: 0.02%
Covered Lines: 110
Relevant Lines: 113

💛 - Coveralls

@spydon spydon merged commit 17709ad into main Oct 20, 2024
5 checks passed
@spydon spydon deleted the luan.fix-empty-subset-bug branch October 20, 2024 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash when many collision happen
3 participants