Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catalog page changes #2312

Closed
1 of 3 tasks
yashmehrotra opened this issue Oct 1, 2024 · 2 comments · May be fixed by #2321
Closed
1 of 3 tasks

Catalog page changes #2312

yashmehrotra opened this issue Oct 1, 2024 · 2 comments · May be fixed by #2321
Milestone

Comments

@moshloop
Copy link
Member

moshloop commented Oct 2, 2024

@yashmehrotra - I don't think we want to default change listing to 7d, it is too long a period - 95% of the time the 2d is enough, and if not then you can just increase it -

For catalog listing - we should probably not set anything and let the server define a default, We can tackle different ranges at a later point in time (when we decide if is a server default and/or user override is possible - with protections to ensure performance impact is understand)

@yashmehrotra
Copy link
Member Author

I don't think we want to default change listing to 7d, it is too long a period - 95% of the time the 2d is enough, and if not then you can just increase it

Agreed, but l think lets do 3d instead of 2d because of the summary view

@moshloop moshloop added this to the v1.0.0 milestone Nov 4, 2024
@moshloop moshloop closed this as completed Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants