From f0b592fae7dad82608c84618611cf80a196330ca Mon Sep 17 00:00:00 2001 From: Mateusz Morusiewicz <11313015+Ruteri@users.noreply.github.com> Date: Fri, 30 Aug 2024 13:03:21 +0200 Subject: [PATCH 1/2] Excludes mnd in addition to gomnd --- .golangci.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/.golangci.yaml b/.golangci.yaml index e1e6a2e..bdb9e65 100644 --- a/.golangci.yaml +++ b/.golangci.yaml @@ -11,6 +11,7 @@ linters: - godot - godox - gomnd + - mnd - lll - nestif - nilnil From cb02f0ef6f9583e5e691bb302b56c317bdbb49ff Mon Sep 17 00:00:00 2001 From: Mateusz Morusiewicz <11313015+Ruteri@users.noreply.github.com> Date: Fri, 30 Aug 2024 13:16:13 +0200 Subject: [PATCH 2/2] Updates golangci and adds pinned installs in README --- .github/workflows/checks.yml | 4 ++-- README.md | 8 ++++---- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/.github/workflows/checks.yml b/.github/workflows/checks.yml index 75f2eb7..f14fdde 100644 --- a/.github/workflows/checks.yml +++ b/.github/workflows/checks.yml @@ -43,10 +43,10 @@ jobs: run: go install honnef.co/go/tools/cmd/staticcheck@v0.4.2 - name: Install golangci-lint - run: go install github.com/golangci/golangci-lint/cmd/golangci-lint@v1.55.0 + run: go install github.com/golangci/golangci-lint/cmd/golangci-lint@v1.60.3 - name: Install NilAway - run: go install go.uber.org/nilaway/cmd/nilaway@latest + run: go install go.uber.org/nilaway/cmd/nilaway@v0.0.0-20240821220108-c91e71c080b7 - name: Lint run: make lint diff --git a/README.md b/README.md index d48545d..22a21b4 100644 --- a/README.md +++ b/README.md @@ -41,10 +41,10 @@ make build-httpserver **Install dev dependencies** ```bash -go install mvdan.cc/gofumpt@latest -go install honnef.co/go/tools/cmd/staticcheck@latest -go install github.com/golangci/golangci-lint/cmd/golangci-lint@latest -go install github.com/daixiang0/gci@latest +go install mvdan.cc/gofumpt@v0.4.0 +go install honnef.co/go/tools/cmd/staticcheck@v0.4.2 +go install github.com/golangci/golangci-lint/cmd/golangci-lint@v1.60.3 +go install go.uber.org/nilaway/cmd/nilaway@v0.0.0-20240821220108-c91e71c080b7 ``` **Lint, test, format**