-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RFE] make CI tests of update-ssh-keys work again #1081
Labels
kind/debt
Technological debt.
Comments
github-project-automation
bot
moved this to 📝 Needs Triage
in Flatcar tactical, release planning, and roadmap
Jun 16, 2023
dongsupark
moved this from 📝 Needs Triage
to 🪵Backlog
in Flatcar tactical, release planning, and roadmap
Jun 16, 2023
dongsupark
added
kind/debt
Technological debt.
and removed
kind/feature
A feature request
labels
Jun 16, 2023
Recently discussed with @t-lo , and kind of agreed that it would be better to simply rewrite every test in Rust. |
dongsupark
moved this from 🪵Backlog
to 🌱 Upcoming / Focus
in Flatcar tactical, release planning, and roadmap
Jun 27, 2023
dongsupark
moved this from 🌱 Upcoming / Focus
to ⚒️ In Progress
in Flatcar tactical, release planning, and roadmap
Jul 11, 2023
dongsupark
moved this from ⚒️ In Progress
to 🪵Backlog
in Flatcar tactical, release planning, and roadmap
Sep 26, 2023
github-project-automation
bot
moved this from 🪵Backlog
to Implemented
in Flatcar tactical, release planning, and roadmap
Nov 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Current situation
CI tests of update-ssh-keys do not work at all, due to a missing python2 binary in the default distros in these days. The python tests were written in 2017, and since then they have been very little touched. If we simply replace python2 with python3, then it fails like:
Implementation options
The simplest way to fix this issue to migrate the code to python3. That should be straightforwards.
Another approach would be to simply rewrite every test in Rust, just like the main code of update-ssh-keys. That makes more sense in terms of maintenance, as the repo is currently a strange mix of Rust and Python.
The text was updated successfully, but these errors were encountered: