app-admin/etcd-wrapper: bump etcd version #2311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tormath1
had a problem deploying
to
development
GitHub Actions
Error
tormath1
force-pushed
the
tormath1/etcd
branch
from
ba46fc3
to
e0ef3ee
Compare
tormath1
had a problem deploying
to
development
GitHub Actions
Error
krnowak
approved these changes
Sep 13, 2024
changelog/updates/2024-09-12-etcd.md
Outdated
| @@ -0,0 +1 @@ | |||
| - etcd ([3.5.16](https://github.com/etcd-io/etcd/releases/tag/v3.5.16)) | |||
There was a problem hiding this comment.
Etcd has some wacky changelog situation - the tagged commit has no changelog, the release branches have no changelog. The changelogs for all the release branches are in the main branch, so let's point there instead.
Suggested change
| - etcd ([3.5.16](https://github.com/etcd-io/etcd/releases/tag/v3.5.16)) | |
| - etcd ([3.5.16](https://github.com/etcd-io/etcd/blob/96e17d38e244ef18756a55d33066f2893402794b/CHANGELOG/CHANGELOG-3.5.md#v3516-2024-09-10)) |
There was a problem hiding this comment.
Thanks for the suggestion!
required for Kubernetes 1.31 external etcd Signed-off-by: Mathieu Tortuyaux <[email protected]>
tormath1
force-pushed
the
tormath1/etcd
branch
from
e0ef3ee
to
100a449
Compare
tormath1
had a problem deploying
to
development
GitHub Actions
Failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
required for Kubernetes 1.31 external etcd
Noticed here: flatcar/mantle#557
NOTE: This does not mean that Kubernetes 1.31 does not work on Flatcar, it means that "out of the box" you can't use shipped etcd from Flatcar as external etcd node.
changelog/directory (user-facing change, bug fix, security fix, update)/bootand/usrsize, packages, list files for any missing binaries, kernel modules, config files, kernel modules, etc.