Skip to content

Commit

Permalink
dependabot: Ignore docusaurus packages
Browse files Browse the repository at this point in the history
  • Loading branch information
@bbhtt
bbhtt committed Jul 15, 2024
1 parent 6e35caa commit 1ad16de
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions .github/dependabot.yml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@ updates:
docusaurus:
patterns:
- "@docusaurus/*"
ignore:
- dependency-name: "@docusaurus/*"
- package-ecosystem: "github-actions"
directory: "/"
schedule:
Expand Down

7 comments on commit 1ad16de

@razzeee
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why? This is not a good idea, we will have to update sooner or later, this just complicates/obfuscates things.

@bbhtt
Copy link
Contributor Author

@bbhtt bbhtt commented on 1ad16de Jul 15, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why? This is not a good idea, we will have to update sooner or later, this just complicates/obfuscates things.

Unless the search issue gets fixed, updating will break things. There's a high chance a bot PR gets merged accidentally.

Having a working search is important because there's too many appstream and linter error codes to search.

We can manually update whenever it is fixed.

@razzeee
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unless the search issue gets fixed, updating will break things. There's a high chance a bot PR gets merged accidentally.

Sure, but IMO setting them to draft is enough of a safety net

@bbhtt
Copy link
Contributor Author

@bbhtt bbhtt commented on 1ad16de Jul 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That doesn't stop it from creating PRs for subsequent updates beyond 3.4.0 ?

@razzeee
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

depends on config, everything 3.4.x can be folded into the draft MR, but a major or minor would create a new PR. Unless we ignore it, but not sure if the ignore syntax really works for groups, as you tried.

I guess let's at least have an issue, to remind us, that we need to remove this ignore?

@bbhtt
Copy link
Contributor Author

@bbhtt bbhtt commented on 1ad16de Jul 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I opened an issue upstream when trying to patch it gabrielcsapo/docusaurus-plugin-search-local#82

@razzeee
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I'm subscribed to that, but I would like us to remove this at one point, even if we end up dropping that addon

Please sign in to comment.