Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include link to GitHub Actions log in PR #239

Open
wjt opened this issue Oct 4, 2021 · 4 comments
Open

Include link to GitHub Actions log in PR #239

wjt opened this issue Oct 4, 2021 · 4 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@wjt
Copy link
Contributor

wjt commented Oct 4, 2021

If a weird PR is filed, it is useful to have a look at the checker's debug output.

GitHub Actions have access to a whole host of environment variables which describe the context that the action is running in. So we should be able to build a link to the current workflow run, and include a link in the pull request message.

https://github.com/$GITHUB_REPOSITORY/actions/runs/$GITHUB_RUN_ID
@gasinvein
Copy link
Collaborator

I hope we'll move away from the shared org-wide action some day. When/if we do, I guess this feature won't be needed?

@wjt
Copy link
Contributor Author

wjt commented Oct 4, 2021

It still might be easier to have a link in the PR rather than needing to dig into the Actions tab.

@wjt wjt added good first issue Good for newcomers enhancement New feature or request labels Oct 4, 2021
@vchernin
Copy link
Contributor

vchernin commented Dec 2, 2021

If I understand correctly, for now, this means give a log to the hourly f-e-d-c run that triggered that PR?

So for example:

https://github.com/flathub/flathub/runs/$GITHUB_RUN_ID?check_suite_focus=true

With 4392377410 for GITHUB_RUN_ID gives:

https://github.com/flathub/flathub/runs/4392377410?check_suite_focus=true

They could also be sent to the raw logs:

https://github.com/flathub/flathub/commit/8130805a528c4bc800f3d611dfcede4cc3661000/checks/4392377410/logs

@dreua
Copy link

dreua commented Jan 4, 2023

I wasn't aware those logs were available at all and I did ask for them in #286 . Definitely add those links!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

4 participants