Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Electron updater doesn't update on checksum changes #365

Open
orowith2os opened this issue Apr 26, 2023 · 0 comments
Open

Electron updater doesn't update on checksum changes #365

orowith2os opened this issue Apr 26, 2023 · 0 comments

Comments

@orowith2os
Copy link

Currently, the Electron data checker only checks for the version inside of the yml file. This is fine for a majority of use cases, as they update their versions when making an update.

However, this doesn't work for ArmCord, as they have a build server which provides constantly rebuilt binaries against certain versions of Electron. They don't update the versions, only checksums.

This means that data checking for ArmCord is broken, and it will remain on an old version of ArmCord until they update the ArmCord version. This isn't desired.

https://github.com/flathub/xyz.armcord.ArmCord/blob/master/xyz.armcord.ArmCord.yml#L49
https://build.armcord.xyz/stable/v21.4.4/latest-linux.yml
https://github.com/flathub/flatpak-external-data-checker/blob/master/src/checkers/electronchecker.py

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant