Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

automerge-flathubbot-prs leaves stale PRs if there's an update more than once per hour #411

Open
dginovker opened this issue Jan 29, 2024 · 1 comment

Comments

@dginovker
Copy link

image

Screenshot taken from here: https://github.com/flathub/vet.rsc.OpenRSC.Launcher/pulls

Basically, here's what happened:

Time Event
00:30 Upstream updated OpenRSC.jar
01:00 flathubbot opened a new PR for the update
01:30 Upstream updated OpenRSC.jar again
02:00 flathubbot opened a PR for the update (again)
02:30 Upstream updated OpenRSC.jar a third time
03:00 flathubbot opened a PR for the third time
04:00 flathubbot merged the third PR

However, the 1st and 2nd (now with a merge conflict) are now sitting there stale.

Possible solutions:

  • Make flathubbot auto close its old PRs
  • Make flathubbot prioritizing merging its PRs over opening new ones
    • The following hour it can still make a new PR, but this way it will merge and get rid of the old one first
  • Make flathubbot update its existing PRs
@wjt
Copy link
Contributor

wjt commented Jan 29, 2024

I can see why this is annoying, but it looks like you are not tracking releases of OpenRSC.jar, but builds from the development branch. That's really not what this tool was designed for.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants