Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrapper is probably spamming terminal when invoking n vim #12

Open
florianb opened this issue Mar 16, 2022 · 7 comments
Open

Wrapper is probably spamming terminal when invoking n vim #12

florianb opened this issue Mar 16, 2022 · 7 comments

Comments

@florianb
Copy link
Contributor

Hi - i am pretty new to the flathub universe. So it might be i ended up in the wrong repo regarding this issue.

I installed Neovim using Flathub. When running io.neovim.nvim the shell prints three additional lines regarding the wrapper:

❯ nvim
nvim-wrapper-wrapper: Setting up NPM packages
nvim-wrapper-wrapper: Setting up Cargo packages
nvim-wrapper-wrapper: Setting up Python packages

So in that regard:

Is it possible to mute these wrapper mesages?

If not would this be the right place to discuss this, and would a PR be possible be accepted?

Thanks in advance – Florian

@gasinvein
Copy link
Collaborator

A patch adding an option to suppress the messages would be nice, yes.

@florianb
Copy link
Contributor Author

I would happily provide a PR. What would you say is a good approach?

  1. Removing the the output per default allowing a debug-specific opt-in,
  2. Keeping the functionality as it is providing a opt-out, or
  3. Trying to make a educated guess about the calling surroundings (not sure if this possible, though) and try to switch the message smartly?

I am fairly new to Flathub so i have to dig into the overall functionality to get an idea about a possible idiomatic approach. So any hints are welcome.

@gasinvein
Copy link
Collaborator

Providing opt-out seems fine. If printing debug messages is controlled by an environment variable, it's default value can be easily altered in the app finish-args.

@florianb
Copy link
Contributor Author

Awesome - i would then propose introducing FLATPAK_IDE_QUIET:0 as a mix of FLATPAK_IDE_ENV and the widely used quiet option.

If you're fine i'd open a PR.

@gasinvein
Copy link
Collaborator

gasinvein commented Mar 18, 2022

I'd rather have it the other way round - something like FLATPAK_IDE_LOGLEVEL with values 0 for "quiet", 1 by default for current behaviour. And then greater numbers can be used in future for more verbose logging.

@florianb
Copy link
Contributor Author

Aye - i create a PR. :)

@CleoMenezesJr
Copy link

I just merged the PR flathub/io.neovim.nvim#57 which implements #17.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants