Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure website is aware of the new custom tag #2557

Closed
barthalion opened this issue Feb 6, 2024 · 4 comments
Closed

Ensure website is aware of the new custom tag #2557

barthalion opened this issue Feb 6, 2024 · 4 comments

Comments

@barthalion
Copy link
Member

barthalion commented Feb 6, 2024

Hmm, yeah, I guess I must have implemented it first with <custom>, then realized it's not what appstream-glib does. @razzeee we're going to have to switch backend and frontend to use the new field too at some point.

Originally posted by @barthalion in flathub-infra/flat-manager-hooks#101 (comment)

@razzeee
Copy link
Member

razzeee commented Feb 6, 2024

Worst case this needs to be done before libappstream, but I'll try to get to it this week

@barthalion
Copy link
Member Author

Yeah, we should do that earlier. I can handle the backend part.

@razzeee
Copy link
Member

razzeee commented Feb 6, 2024

I guess we also handle both https://github.com/flathub-infra/website/blob/main/backend/app/utils.py#L216

guess custom will just overwrite stuff from metadata, which should be fine

@barthalion
Copy link
Member Author

Yeah, I guess we're backwards compatible after all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants