Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only the i386 version should be installable by the user #2

Closed
MateusRodCosta opened this issue Aug 11, 2017 · 6 comments
Closed

Only the i386 version should be installable by the user #2

MateusRodCosta opened this issue Aug 11, 2017 · 6 comments

Comments

@MateusRodCosta
Copy link
Collaborator

Currently if I use flatpak remote-ls flathub using the --arch parameter for all 4 architectures a flatpak currently can support, the search will show this app for all of them.
This game's flatpak is packaged in a way that it uses the python binary which is already distributed with the game, which is 32-bits and needs 32-bit libraries. So, only-arches is used to limit the distribution to only the i386 flatpak.

Using a x86_64 system and running flatpak install flathub com.scoutshonour.Digital installs the x86_64 version, which predictably fails to actually run. I have already checked the build pages after some commits and it seems to really don't do the build steps when it notices the architecture should be skipped.

Even so, for some reason this flatpak seems to be available for every architecture instead of just i386.
This could be fixed by undestanding why flathub makes it available for all arches and fixing that OR, since python is a interpreted language, just change the flatpak to use the python 2 interpreter from the runtime.

@TingPing Thoughts on this?

@TingPing
Copy link
Member

It could be some accidental leftover of the builder i don't know. @alexlarsson or @ramcq would probably know more.

@barthalion
Copy link
Member

I wonder if test builds aren't cached and later uploaded anyway, even with only-arches.

@TingPing
Copy link
Member

@alexlarsson @ramcq, Is there any way to solve this? The buildbot should probably delete old arches if a flathub.json specifies only-arches to avoid situations like this where broken unusable builds are left in the other arches.

@nedrichards
Copy link
Member

@ramcq has manually purged the x86-64 version. This should be reflected in the repo when the next app is updated.

@ramcq
Copy link

ramcq commented Feb 13, 2018

(and arm and aarch64 - this is all due to flathub-infra/buildbot-config#1 - once you take an arch away by changing flatpak.json, it just lingers around like a bad smell...)

@MateusRodCosta
Copy link
Collaborator Author

I will do #9 instead. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants