Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporary directory not cleaned up (regression) #26

Open
phloxic opened this issue May 19, 2021 · 0 comments
Open

Temporary directory not cleaned up (regression) #26

phloxic opened this issue May 19, 2021 · 0 comments

Comments

@phloxic
Copy link
Contributor

phloxic commented May 19, 2021

With recent changes shutil now tries (and fails silently) to remove a tree with path generated here: https://github.com/flavioribeiro/video-thumbnail-generator/blob/master/generator#L195 which is actually the so-called 'prefix' of the temporary png filenames.

shutil instead should try to remove TMP_FRAMES_PATH presumably.

However I am not sure how this fares with the new directory processing feature.
I also don't know in which scenario the TMP_FRAMES_PATH is recreated: https://github.com/flavioribeiro/video-thumbnail-generator/blob/master/generator#L193-L194 (instead of creating a new temporary directory safely).

phloxic added a commit to phloxic/video-thumbnail-generator that referenced this issue May 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant