Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

import Identicon issue #3

Open
McPo opened this issue May 29, 2018 · 2 comments
Open

import Identicon issue #3

McPo opened this issue May 29, 2018 · 2 comments

Comments

@McPo
Copy link

McPo commented May 29, 2018

There appears to be an issue with importing the library from pypi via pip and virtualenv. Note, I can install other libraries and import them fine. So Im fairly certain the issue is with this library.

@McPo
Copy link
Author

McPo commented May 29, 2018

The issue is caused by what appears to be a mix of two different python libraries.

You have placed the library on at 0.1
The latest code change suggests the version is really 0.1.1

However there is an Identicon==1.0. And it appears to be causing issues.
Might be best to bump the library to 1.1 at least.

https://pypi.org/project/identicon/#history

@flavono123
Copy link
Owner

I knew about it.

I've got the pip name as Identicon on followed thread:
shnjp/identicon#2

To bump the version 1.1, I think we have to set some features for that milestone then develop them.
You've done about that work, version 0.2.0 (Thanks for contribution, btw 😄)

One of the features would be 'not overlap the foreground color and the background color' I think(Critical .. we can see the identicon!).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants