Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Serverless: Load ABI file from the deployments folder of the contracts directory #275

Open
EmperorOrokuSaki opened this issue Jun 7, 2023 · 2 comments
Open

Serverless: Load ABI file from the deployments folder of the contracts directory #275

EmperorOrokuSaki opened this issue Jun 7, 2023 · 2 comments
Assignees
@lazyfuhrer
Labels
backend enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed quality-of-life refactor Improve existing feature
Milestone
MVP

Comments

@EmperorOrokuSaki
Copy link
Collaborator

We might want to load the ABI from our contracts directory with the latest deployments. The serverless side currently has its own copy of the ABI. In the end, it is always going to need that copy because it's packed into the libs layer and uploaded to AWS. Also considering the fact that we do deployments to goerli, main-net, and Mumbai, it's going to be tricky to decide which one to use.

If we can figure out a way to avoid copying the FleekERC721.json ABI file from non-fungible-apps/contracts/deployments, we can make sure serverless always uses the latest deployed ABI.
@EmperorOrokuSaki EmperorOrokuSaki added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed quality-of-life backend refactor Improve existing feature labels Jun 7, 2023
@EmperorOrokuSaki EmperorOrokuSaki added this to the MVP milestone Jun 7, 2023
@lazyfuhrer
Copy link

assign me @EmperorOrokuSaki

@EmperorOrokuSaki
Copy link
Collaborator Author

EmperorOrokuSaki commented Jun 12, 2023 •
edited
Loading

assign me @EmperorOrokuSaki

Of course! Thank you for the response. Please feel free to begin working on the task. You can start by reading the contribution guide:
https://github.com/fleekxyz/non-fungible-apps/blob/main/CONTRIBUTING.md

Let me know if you have any issues/questions :)
My discord handle: ! Nima Ra#8929

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lazyfuhrer lazyfuhrer

Labels
backend enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed quality-of-life refactor Improve existing feature
Projects
None yet
Milestone
MVP
Development

No branches or pull requests
2 participants
@lazyfuhrer @EmperorOrokuSaki