Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve quality of examples #3

Open
6 tasks
wilcowijbrandi opened this issue Jul 13, 2015 · 0 comments
Open
6 tasks

Improve quality of examples #3

wilcowijbrandi opened this issue Jul 13, 2015 · 0 comments

Comments

@wilcowijbrandi
Copy link
Member

I have noticed these examples are not of a desired quality yet. If you are looking for examples of FPAI Apps, I would still recommend you take a look at the fpai-apps repository (https://github.com/flexiblepower/fpai-apps). The simulated appliances in there should also be fairly easy to understand.

The following this should be checked before a release:

  • Make sure all examples use immutable objects to send messages. The current example is WRONG and will lead to errors!
  • Check for references of the ScheduledExecutorService and TimeService, both are deprecated and should be replaced by the FlexiblePowerContext
  • Check if tests function properly
  • Apply checkstyle
  • Add to Jenkins (http://fpai-ci.sensorlab.tno.nl)
  • Improve documentation in code, these are examples after all
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant