Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup documentation #13

Open
victorgarcia98 opened this issue Aug 2, 2023 · 2 comments
Open

Setup documentation #13

victorgarcia98 opened this issue Aug 2, 2023 · 2 comments

Comments

@victorgarcia98
Copy link
Collaborator

In order to boost the adoption of this package, I suggest adding documentation.

In the past, I worked on the setup of a SPHINX documentation in TOX:

https://github.com/victorgarcia98/s2-ws-json-python/tree/main

And got it published in ReadTheDocs:

https://s2-ws-json-python.readthedocs.io/en/latest/_autosummary/s2wsjson.common.timer.html#module-s2wsjson.common.timer

@lfse-slafleur
Copy link
Member

We should definitely generate some type of documentation. An idea I have is to reuse the documentation provided to pydantic. For example: f255934#diff-1402cdc5485e1b35c6fc47f25e172db57b4cfc4fab64fb6a2668ccdd1171f0f3R67

Every field currently already has a bunch of docs and it would be great if we could utilize them. How that exactly could work, I am unsure. I already checked pydantic and it does not seem to have a docs generator or something similar. Perhaps it does have it but I overlooked it.

Btw, what did you write the RST in your example? I saw docs for the json() and dict() functions but I cannot find the definitions.

@victorgarcia98
Copy link
Collaborator Author

We should definitely generate some type of documentation. An idea I have is to reuse the documentation provided to pydantic. For example: f255934#diff-1402cdc5485e1b35c6fc47f25e172db57b4cfc4fab64fb6a2668ccdd1171f0f3R67

Good point!

After a quick search, I found this sphinx package that could be useful, I'll try to test it 😄

Btw, what did you write the RST in your example? I saw docs for the json() and dict() functions but I cannot find the definitions.

I think it's also showing the docs of the inherited methods, in this case, from the ValidateValusMixin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants