Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] scully-plugin-angular-delay - Angular 10 #37

Open
etavener opened this issue Jul 15, 2020 · 4 comments
Open

[BUG] scully-plugin-angular-delay - Angular 10 #37

etavener opened this issue Jul 15, 2020 · 4 comments

Comments

@etavener
Copy link
Contributor

Describe the bug
I upgraded my Angular 9 app to Angular 10.

After doing a build with ng build --prod --stats-json

I got this error (this error didn't appear before):

Error: A stats-es2015.json is required for the 'delayAngular' plugin.
Please run 'ng build' with the '--stats-json' flag

I checked my dist folder and there was a stats.json file not a stats-es2015.json. I renamed the file to stats-es2015.json and the error disappeared.

I think you should just check for both files and use the one that exists and if neither exists show the error.

Check which provider is affected:
[] AWS
[] Azure
[] Google Cloud Platform

Check which framework is affected:
[x] Angular
[] Nodejs
[] Serverless
[] Lambda
[] Infrastructure as a code

Additional context
Add any other context about the problem here.

@etavener etavener changed the title [BUG] Angular 10 [BUG] scully-plugin-angular-delay - Angular 10 Jul 15, 2020
@etavener
Copy link
Contributor Author

Additionally, if you checked for stats.json first and if that doesn't exist check for stats-es2015.json and if neither exists show error. Then you could remove the need for a tsConfig and it's path.

@wickstargazer
Copy link
Member

i have to look into tsconfig requirement, however the stats.json is a valid point. We can check both to have backward compatibility :) ...

@wickstargazer
Copy link
Member

looked into it quickly, we could make a regex expression for stats.json and remove tsconfig entirely ans you suggest :D

@etavener
Copy link
Contributor Author

Sounds great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants