Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

_status not reset after FluentLoggerError.MissingTag #94

Open
haosu opened this issue Jun 14, 2018 · 1 comment
Open

_status not reset after FluentLoggerError.MissingTag #94

haosu opened this issue Jun 14, 2018 · 1 comment

Comments

@haosu
Copy link

haosu commented Jun 14, 2018

On FluentLoggerError.MissingTag errors the reconnect handler (https://github.com/fluent/fluent-logger-node/blob/master/lib/sender.js#L453) does not set _status back to established, and does not re-emit the connect event.

Background: I've implemented a bounded event queue that queues if the fluent-logger is not connected, and attempts to flush when the logger reconnects. In cases of event data errors callers cannot be accurately notified of when the logger reconnects either through looking at _status or depending on the connect event.

@okkez
Copy link
Contributor

okkez commented Jun 18, 2018

We cannot refer _status from user code. Because _status is a private member.
So I've added a new event reconnect to handle reconnection.
Could you try #95? Is it ok? Feel free to comment, please.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants