Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup large unused files #375

Merged
merged 1 commit into from
Sep 10, 2024
Merged

Cleanup large unused files #375

merged 1 commit into from
Sep 10, 2024

Conversation

orgads
Copy link
Contributor

@orgads orgads commented Feb 29, 2024

Reduces the alpine image from 46M to 36M and debian image from 210M to 195M.

yajl parts can be removed if/when brianmario/yajl-ruby#228 is merged and released.

@orgads orgads force-pushed the reduce-size branch 2 times, most recently from d13ed26 to b9e332b Compare February 29, 2024 20:02
@kenhys kenhys self-requested a review March 21, 2024 02:50
Copy link

This PR has been automatically marked as stale because it has been open 30 days with no activity. Remove stale label or comment or this PR will be closed in 7 days

@github-actions github-actions bot added the stale Inactive and will be closed automatically label Aug 29, 2024
@orgads
Copy link
Contributor Author

orgads commented Aug 29, 2024

Missed a comment. Don't close.

@orgads
Copy link
Contributor Author

orgads commented Sep 5, 2024

Wait with this, I have some more improvements.

Reduces the alpine image from 46M to 36M, and debian image
from 210M to 195M.

yajl parts can be removed if/when
brianmario/yajl-ruby#228 is merged and
released.

Signed-off-by: Orgad Shaneh <[email protected]>
Copy link
Contributor

@kenhys kenhys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Here is the simple stats:

 podman images |grep fluentd
localhost/fluentd-alpine             latest             2918f8d3973c  17 seconds ago      49.9 MB
localhost/fluentd-debian             latest             4ae0e7ea34fc  About a minute ago  220 MB
localhost/fluentd-alpine-reduce      latest             92dcc72f2f3c  4 minutes ago       39.1 MB
localhost/fluentd-debian-reduce      latest             a4d016dcfb19  6 hours ago         204 MB

@kenhys kenhys merged commit b08a74d into fluent:master Sep 10, 2024
5 checks passed
@orgads orgads deleted the reduce-size branch September 10, 2024 09:43
@orgads
Copy link
Contributor Author

orgads commented Sep 10, 2024

Thanks @kenhys. With docker-library/ruby#472 the debian images can be reduced even more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale Inactive and will be closed automatically
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants