Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mutation observer and testing #12

Open
wants to merge 18 commits into
base: master
Choose a base branch
from

Conversation

borosr
Copy link
Contributor

@borosr borosr commented Jun 2, 2022

We added a demo application to the project, which is using Vue 3 to demonstrate how guardian works, it shows the caught values. Also added cypress to the project and it is testing guardian through the demo app.

Copy link
Member

@PumpkinSeed PumpkinSeed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried the demo with the commands from the read me, but it's not working:

Uncaught ReferenceError: Guardian is not defined
    at (index):13:9

Probably it doesn't know what is localhost:4173

@borosr
Copy link
Contributor Author

borosr commented Jun 6, 2022

@PumpkinSeed thank you for the feedback, we probably missed to update the readme with the proper command. Meanwhile, you can try with with the following commands:

npm install
npm run demo:install
npm run build
npm preview # this command will block your terminal, please open a new tab to continue
npm run demo:dev # this command will block your terminal, please open a new tab to continue

Running the cypress tests:

npm run cypress:open
# or, to run tests in headless mode
npx cypress run --headless -b chrome 

@borosr borosr requested a review from PumpkinSeed June 7, 2022 06:39
Copy link
Member

@PumpkinSeed PumpkinSeed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove API keys from everywhere.

src/guardian/helper.ts Outdated Show resolved Hide resolved
src/guardian/helper.ts Show resolved Hide resolved
demo/index.html Show resolved Hide resolved
@PumpkinSeed PumpkinSeed self-requested a review April 10, 2023 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants