From 24d5d618b58510d97d140f076c8701acfa76cd4d Mon Sep 17 00:00:00 2001 From: Daniel Chevalier Date: Fri, 8 Dec 2023 14:19:14 -0500 Subject: [PATCH] Add scrollbar to log details (#6917) ![](https://media.giphy.com/media/Y4pAQv58ETJgRwoLxj/giphy-downsized.gif) The only part of the logging display that I found confusing was that there was no scroll bar, so I have added one here. Fixes https://github.com/flutter/devtools/issues/6797 --- .../lib/src/screens/logging/_log_details.dart | 14 ++++++++------ .../release_notes/NEXT_RELEASE_NOTES.md | 2 +- 2 files changed, 9 insertions(+), 7 deletions(-) diff --git a/packages/devtools_app/lib/src/screens/logging/_log_details.dart b/packages/devtools_app/lib/src/screens/logging/_log_details.dart index 2cf11e9f84c..9c818b93124 100644 --- a/packages/devtools_app/lib/src/screens/logging/_log_details.dart +++ b/packages/devtools_app/lib/src/screens/logging/_log_details.dart @@ -85,12 +85,14 @@ class _LogDetailsState extends State title: _LogDetailsHeader(log: log), child: Padding( padding: const EdgeInsets.all(denseSpacing), - child: SingleChildScrollView( - controller: scrollController, - child: SelectableText( - log?.prettyPrinted() ?? '', - textAlign: TextAlign.left, - style: theme.fixedFontStyle, + child: Scrollbar( + child: SingleChildScrollView( + controller: scrollController, + child: SelectableText( + log?.prettyPrinted() ?? '', + textAlign: TextAlign.left, + style: theme.fixedFontStyle, + ), ), ), ), diff --git a/packages/devtools_app/release_notes/NEXT_RELEASE_NOTES.md b/packages/devtools_app/release_notes/NEXT_RELEASE_NOTES.md index 6bf8e9fe3cb..f998e62f48e 100644 --- a/packages/devtools_app/release_notes/NEXT_RELEASE_NOTES.md +++ b/packages/devtools_app/release_notes/NEXT_RELEASE_NOTES.md @@ -43,7 +43,7 @@ TODO: Remove this section if there are not any general updates. ## Logging updates -TODO: Remove this section if there are not any general updates. +* Added scrollbar to details pane. - [#6917](https://github.com/flutter/devtools/pull/6917) ## App size tool updates