Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Dart grammar for extension type highlighting and other fixes #6837

Merged
merged 7 commits into from
Nov 30, 2023
Merged

Update Dart grammar for extension type highlighting and other fixes #6837

merged 7 commits into from
Nov 30, 2023

Conversation

parlough
Copy link
Member

Updates from v1.2.0 to v1.2.5 from https://github.com/dart-lang/dart-syntax-highlight/blob/master/grammars/dart.json, with the primary change being support for highlighting extension type as a combined keyword and various comment fixes.

Complete changelog:

1.2.5 (2023-11-27)

  • Don't mark empty double backticks as inline code.

1.2.4 (2023-11-26)

  • Include the opening $ of a simple identifier string interpolation
    inside the string.interpolated.expression.dart scope.

1.2.3 (2023-09-11)

  • Removed support for inline class keyword and added support for extension type.

1.2.2 (2023-06-28)

  • Added support for inline class.

1.2.1 (2023-05-04)

  • Fixed highlighting of comments inside type arguments.

@parlough parlough marked this pull request as ready for review November 27, 2023 20:38
@parlough parlough requested a review from a team as a code owner November 27, 2023 20:38
@parlough parlough requested review from bkonyi and removed request for a team November 27, 2023 20:38
bkonyi
bkonyi approved these changes Nov 27, 2023
View reviewed changes
Copy link
Contributor

@bkonyi bkonyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@bkonyi bkonyi requested a review from kenzieschmoll November 27, 2023 20:53
@bkonyi
Copy link
Contributor

bkonyi commented Nov 27, 2023

FYI @kenzieschmoll

kenzieschmoll
kenzieschmoll approved these changes Nov 29, 2023
View reviewed changes
Copy link
Member

@kenzieschmoll kenzieschmoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one comment and lgtm

@parlough @kenzieschmoll
Add link to PR
f51630c 
Co-authored-by: Kenzie Davisson <[email protected]>
@parlough parlough added the autosubmit Merge PR when tree becomes green via auto submit App label Nov 29, 2023
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Nov 29, 2023
@auto-submit Auto-submit
Copy link

auto-submit bot commented Nov 29, 2023

auto label is removed for flutter/devtools/6837, due to - The status or check suite devtools_app integration-test integration_dart2js - flutter - shard 1/3 has failed. Please fix the issues identified (or deflake) before re-applying this label.

@parlough parlough merged commit e3aaef2 into flutter:master Nov 30, 2023
22 checks passed
@parlough parlough deleted the misc/syntax-highlighting-extension-types branch November 30, 2023 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kenzieschmoll kenzieschmoll kenzieschmoll approved these changes

@bkonyi bkonyi bkonyi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@parlough @bkonyi @kenzieschmoll