[Impeller] remove std::vector usage in render pass vk. #57132
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
| color_ref.layout = vk::ImageLayout::eGeneral; | ||
| color_refs[0] = color_ref; | ||
| attachments.push_back(color0_.value()); | ||
| color_refs[color_index++] = color_ref; |
There was a problem hiding this comment.
I suggest using .at(color_index++) instead of [color_index++]. The former performs range checking in debug for throwing the exceptions (which we disable). The latter is free to write into garbage memory. Some safety net in debug should be good to have IMO.
There was a problem hiding this comment.
I can add a break if we hit more than 16 attachments. otherwise there shouldn't (TM) need to be bounds checks.
There was a problem hiding this comment.
There are other places where the bounds checks would be harder to add so I made them use .at() too.
There was a problem hiding this comment.
Yeah, its hard to imagine cases where we could blow the limit. But the .at() to me also reads better since it implies no reallocations may occur if say the collection was a map.
jonahwilliams
added
the
autosubmit
auto-submit
bot
removed
the
autosubmit
|
auto label is removed for flutter/engine/57132, due to - The status or check suite Linux linux_unopt has failed. Please fix the issues identified (or deflake) before re-applying this label. |
jonahwilliams
added
the
autosubmit
auto-submit
bot
removed
the
autosubmit
|
auto label is removed for flutter/engine/57132, due to - The status or check suite Linux local_engine_builds has failed. Please fix the issues identified (or deflake) before re-applying this label. |
jonahwilliams
added
the
autosubmit
…160128) flutter/engine@b8034f1...e352461 2024-12-11 [email protected] [Impeller] remove std::vector usage in render pass vk. (flutter/engine#57132) 2024-12-11 [email protected] [Linux] Add Multi-Touch Support for Linux (flutter/engine#54214) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Remove std::vector usage in vulkan render pass. Fixed size array + offsets, should be faster than heap allocations.