Removed heap allocations for conical, radial and sweep gradients #57143
+235
−137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaaclarke
commented
Dec 11, 2024
| @@ -35,15 +35,23 @@ class DlConicalGradientColorSource final : public DlGradientColorSourceBase { | |||
| bool equals_(DlColorSource const& other) const override; | |||
|
|
|||
| private: | |||
| template <typename Colors> | |||
There was a problem hiding this comment.
These constructors are so huge but have basically zero logic so I decided not to duplicate them and instead use a template to avoid any sort of bugs where they get out of sync.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 12, 2024
github-merge-queue bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Dec 12, 2024
…160132) flutter/engine@e352461...92de3d0 2024-12-11 [email protected] Removed heap allocations for conical, radial and sweep gradients (flutter/engine#57143) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes flutter/flutter#154650
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.